|
|
Created:
3 years, 7 months ago by Xiaocheng Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine, Xiaocheng Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Idle time spell checker] Correct position passed from undo stack
Idle time spell checker fetches positions to check from undo stack, but
the positions can be invalid since undo stack can store stale information.
This patch corrects the position before calculating the checking range,
so that we don't pass an invalid position to TextIterator, and hence,
fixes the crash.
BUG=715107
Review-Url: https://codereview.chromium.org/2845863002
Cr-Commit-Position: refs/heads/master@{#467596}
Committed: https://chromium.googlesource.com/chromium/src/+/47564c7bf17d2fd560b4390ba714d19d4d9e2550
Patch Set 1 #Patch Set 2 : Fix bot failures... #Messages
Total messages: 21 (16 generated)
Description was changed from ========== [Idle time spell checker] Correct position passed from undo stack BUG=715107 ========== to ========== [Idle time spell checker] Correct position passed from undo stack Idle time spell checker fetches positions to check from undo stack, but the positions can be invalid since undo stack can store stale information. This patch corrects the position before calculating the checking range, so that we don't pass an invalid position to TextIterator, and hence, fixing the crash. BUG=715107 ==========
Description was changed from ========== [Idle time spell checker] Correct position passed from undo stack Idle time spell checker fetches positions to check from undo stack, but the positions can be invalid since undo stack can store stale information. This patch corrects the position before calculating the checking range, so that we don't pass an invalid position to TextIterator, and hence, fixing the crash. BUG=715107 ========== to ========== [Idle time spell checker] Correct position passed from undo stack Idle time spell checker fetches positions to check from undo stack, but the positions can be invalid since undo stack can store stale information. This patch corrects the position before calculating the checking range, so that we don't pass an invalid position to TextIterator, and hence, fixes the crash. BUG=715107 ==========
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL. Regarding the regression test: Currently the only repro is in Gmail, and is in replying a long mail. I tried for a few hours but haven't managed to minimize it... The crash site is in SimplifiedBackwardsTextIterator, which *sometimes* crashes when passed an invalid position, but I haven't figured out the exact crashing conditions yet. Anyway, the fix itself looks pretty reasonable, so I'd like to land it first to stop the crash early. I'll add the regression test later.
lgtm
The CQ bit was unchecked by yosin@chromium.org
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xiaochengh@chromium.org
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2845863002/#ps20001 (title: "Fix bot failures...")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493272150802850, "parent_rev": "a1db173fa4473293335929920dcb90c13f2390d4", "commit_rev": "47564c7bf17d2fd560b4390ba714d19d4d9e2550"}
Message was sent while issue was closed.
Description was changed from ========== [Idle time spell checker] Correct position passed from undo stack Idle time spell checker fetches positions to check from undo stack, but the positions can be invalid since undo stack can store stale information. This patch corrects the position before calculating the checking range, so that we don't pass an invalid position to TextIterator, and hence, fixes the crash. BUG=715107 ========== to ========== [Idle time spell checker] Correct position passed from undo stack Idle time spell checker fetches positions to check from undo stack, but the positions can be invalid since undo stack can store stale information. This patch corrects the position before calculating the checking range, so that we don't pass an invalid position to TextIterator, and hence, fixes the crash. BUG=715107 Review-Url: https://codereview.chromium.org/2845863002 Cr-Commit-Position: refs/heads/master@{#467596} Committed: https://chromium.googlesource.com/chromium/src/+/47564c7bf17d2fd560b4390ba714... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/47564c7bf17d2fd560b4390ba714... |