Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2845863002: [Idle time spell checker] Correct position passed from undo stack (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Idle time spell checker] Correct position passed from undo stack Idle time spell checker fetches positions to check from undo stack, but the positions can be invalid since undo stack can store stale information. This patch corrects the position before calculating the checking range, so that we don't pass an invalid position to TextIterator, and hence, fixes the crash. BUG=715107 Review-Url: https://codereview.chromium.org/2845863002 Cr-Commit-Position: refs/heads/master@{#467596} Committed: https://chromium.googlesource.com/chromium/src/+/47564c7bf17d2fd560b4390ba714d19d4d9e2550

Patch Set 1 #

Patch Set 2 : Fix bot failures... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
Xiaocheng
PTAL. Regarding the regression test: Currently the only repro is in Gmail, and is in ...
3 years, 7 months ago (2017-04-27 01:55:42 UTC) #6
yosin_UTC9
lgtm
3 years, 7 months ago (2017-04-27 03:14:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845863002/1
3 years, 7 months ago (2017-04-27 03:15:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845863002/20001
3 years, 7 months ago (2017-04-27 05:49:31 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 05:55:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/47564c7bf17d2fd560b4390ba714...

Powered by Google App Engine
This is Rietveld 408576698