Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2845853003: [debug] fix case of GC-unsafe access in Debug::HandleDebugBreak. (Closed)

Created:
3 years, 7 months ago by Yang
Modified:
3 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] fix case of GC-unsafe access in Debug::HandleDebugBreak. BUG=v8:6311 R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2845853003 Cr-Commit-Position: refs/heads/master@{#44930} Committed: https://chromium.googlesource.com/v8/v8/+/2920ea59a42fabb0a3121c85395bfa537dfa20d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/debug/debug.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 7 months ago (2017-04-27 12:01:57 UTC) #1
Jakob Kummerow
LGTM, thanks!
3 years, 7 months ago (2017-04-27 12:03:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845853003/1
3 years, 7 months ago (2017-04-27 12:03:38 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 12:27:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2920ea59a42fabb0a3121c85395bfa537df...

Powered by Google App Engine
This is Rietveld 408576698