Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2845803002:
Adding a pid= Chrome-Proxy smoke test (Closed)
DescriptionAdding a pid= Chrome-Proxy smoke test
This verifies that one request per page has pid= and that 5 consecutive
page loads generates 5 unique IDs.
BUG=709516
Review-Url: https://codereview.chromium.org/2845803002
Cr-Commit-Position: refs/heads/master@{#468467}
Committed: https://chromium.googlesource.com/chromium/src/+/c114f768969b6d2ed30148474b4df468b4ca7c88
Patch Set 1 #Patch Set 2 : stale comment #
Total comments: 1
Patch Set 3 : robertogden nit #
Total comments: 1
Patch Set 4 : tbansal nit #Messages
Total messages: 22 (16 generated)
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
ryansturm@chromium.org changed reviewers: + bengr@chromium.org, robertogden@chromium.org
bengr, robertogden: PTAL
bengr, robertogden: PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm % nit https://codereview.chromium.org/2845803002/diff/20001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/smoke.py (right): https://codereview.chromium.org/2845803002/diff/20001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/smoke.py:85: if ('pid=' in directive): you don't need these parens
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tbansal@chromium.org changed reviewers: + tbansal@chromium.org
lgtm with a optional comment. https://codereview.chromium.org/2845803002/diff/40001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/smoke.py (right): https://codereview.chromium.org/2845803002/diff/40001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/smoke.py:94: self.assertEqual(page_loads, len(page_identifiers)) Is it possible that only this assert fails without anything else failing in the test? It seems like this is essentially checking if the for loop ran as many times as it was supposed to?
The CQ bit was checked by ryansturm@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertogden@chromium.org, tbansal@chromium.org Link to the patchset: https://codereview.chromium.org/2845803002/#ps60001 (title: "tbansal nit")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493678310645540,
"parent_rev": "c0fd363129a9a01abe8954eb9b23beadaf6ea984", "commit_rev":
"c114f768969b6d2ed30148474b4df468b4ca7c88"}
Message was sent while issue was closed.
Description was changed from ========== Adding a pid= Chrome-Proxy smoke test This verifies that one request per page has pid= and that 5 consecutive page loads generates 5 unique IDs. BUG=709516 ========== to ========== Adding a pid= Chrome-Proxy smoke test This verifies that one request per page has pid= and that 5 consecutive page loads generates 5 unique IDs. BUG=709516 Review-Url: https://codereview.chromium.org/2845803002 Cr-Commit-Position: refs/heads/master@{#468467} Committed: https://chromium.googlesource.com/chromium/src/+/c114f768969b6d2ed30148474b4d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c114f768969b6d2ed30148474b4d... |
