Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2845763002: Remove DeviceLightEvent implementation (Closed)

Created:
3 years, 7 months ago by juncai
Modified:
3 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, agrieve+watch_chromium.org, kinuko+watch, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, wanming.lin, blink-reviews, einbinder+watch-test-runner_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, blink-reviews-bindings_chromium.org, mlamouri+watch-sensors_chromium.org, haraken, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, shalamov, mlamouri+watch-blink_chromium.org, riju_, Aaron Boodman, mac-reviews_chromium.org, darin (slow to review), Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DeviceLightEvent implementation Per https://crbug.com/336424#c31 DeviceLightEvent is no longer on track for standardization. This CL removes its implementation. BUG=711577 Review-Url: https://codereview.chromium.org/2845763002 Cr-Commit-Position: refs/heads/master@{#467899} Committed: https://chromium.googlesource.com/chromium/src/+/5a16c1d4606ab4efa34570f1ba3622c451d51c1e

Patch Set 1 : remove DeviceLightEvent implementation #

Patch Set 2 : fix layout tests #

Patch Set 3 : rebase #

Patch Set 4 : cleanup #

Patch Set 5 : fix layout tests #

Patch Set 6 : same as previous patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1939 lines) Patch
M content/browser/device_sensors/device_sensor_browsertest.cc View 10 chunks +0 lines, -72 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/device_sensors/device_light_event_pump.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/renderer/device_sensors/device_light_event_pump.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D content/renderer/device_sensors/device_light_event_pump_unittest.cc View 1 chunk +0 lines, -159 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 8 chunks +2 lines, -19 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/test_runner/test_runner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/test_runner/test_runner.cc View 7 chunks +0 lines, -24 lines 0 comments Download
M content/shell/test_runner/web_test_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/device_sensors/device_light_infinity_test.html View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
D content/test/data/device_sensors/device_light_test.html View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M device/generic_sensor/platform_sensor_ambient_light_mac.cc View 1 chunk +30 lines, -2 lines 0 comments Download
M device/sensors/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D device/sensors/ambient_light_mac.h View 1 chunk +0 lines, -43 lines 0 comments Download
D device/sensors/ambient_light_mac.cc View 1 chunk +0 lines, -79 lines 0 comments Download
M device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java View 10 chunks +3 lines, -33 lines 0 comments Download
M device/sensors/android/javatests/src/org/chromium/device/sensors/DeviceSensorsTest.java View 10 chunks +0 lines, -51 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory.h View 5 chunks +0 lines, -7 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_android.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_base.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_base_unittest.cc View 19 chunks +2 lines, -89 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_chromeos.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_default.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_mac.cc View 4 chunks +1 line, -44 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 5 chunks +0 lines, -62 lines 0 comments Download
M device/sensors/device_sensor_host.h View 2 chunks +0 lines, -3 lines 0 comments Download
M device/sensors/device_sensor_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M device/sensors/device_sensor_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/sensors/device_sensor_service.cc View 3 chunks +1 line, -8 lines 0 comments Download
M device/sensors/device_sensors_consts.h View 3 chunks +1 line, -8 lines 0 comments Download
M device/sensors/public/cpp/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
D device/sensors/public/cpp/device_light_data.h View 1 chunk +0 lines, -21 lines 0 comments Download
D device/sensors/public/cpp/device_light_hardware_buffer.h View 1 chunk +0 lines, -17 lines 0 comments Download
D device/sensors/public/cpp/device_sensors_consts.h View 1 chunk +0 lines, -15 lines 0 comments Download
D device/sensors/public/cpp/device_util_mac.h View 1 chunk +0 lines, -18 lines 0 comments Download
D device/sensors/public/cpp/device_util_mac.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M device/sensors/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D device/sensors/public/interfaces/light.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M device/sensors/sensor_manager_android.h View 7 chunks +1 line, -12 lines 0 comments Download
M device/sensors/sensor_manager_android.cc View 3 chunks +1 line, -60 lines 0 comments Download
M device/sensors/sensor_manager_android_unittest.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M services/device/device_service.h View 3 chunks +0 lines, -6 lines 0 comments Download
M services/device/device_service.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/add-listener.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/add-listener-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/create-event.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/create-event-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners.html View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/page-visibility.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/page-visibility-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/rounded-lux-value.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/rounded-lux-value-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/window-property.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/window-property-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTypeNames.json5 View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/device_light/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DOMWindowDeviceLight.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightController.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightController.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEvent.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEvent.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEvent.idl View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEventInit.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/WindowDeviceLight.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/WebKit/public/platform/WebDeviceLightListener.h View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/public/platform/WebPlatformEventType.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/blink_rename_merge_helper/data/idl_blocklist.txt View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 46 (31 generated)
juncai
Please take a look.
3 years, 7 months ago (2017-04-26 23:19:34 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 7 months ago (2017-04-26 23:52:48 UTC) #6
juncai
haraken@chromium.org: Please review changes in //third_party/WebKit dcheng@chromium.org: Please do a security review of removing //device/sensors/public/interfaces/light.mojom ...
3 years, 7 months ago (2017-04-27 00:09:24 UTC) #12
haraken
WebKit LGTM but let's wait for foolip's approval.
3 years, 7 months ago (2017-04-27 00:13:01 UTC) #13
juncai
Since dcheng@ is OOO, add rsesek@ as the reviewer. rsesek@chromium.org: Please do a security review ...
3 years, 7 months ago (2017-04-27 00:14:16 UTC) #15
juncai
foolip@chromium.org: Please take a look.
3 years, 7 months ago (2017-04-27 00:16:42 UTC) #17
dcheng
mojom lgtm
3 years, 7 months ago (2017-04-27 02:16:09 UTC) #18
foolip
lgtm, but note that this is a dupe of https://codereview.chromium.org/2823753002/, pick one to land :)
3 years, 7 months ago (2017-04-27 08:13:15 UTC) #21
Reilly Grant (use Gerrit)
On 2017/04/27 08:13:15, foolip OOO until May 2 wrote: > lgtm, but note that this ...
3 years, 7 months ago (2017-04-27 15:33:14 UTC) #22
jam
lgtm
3 years, 7 months ago (2017-04-27 15:35:37 UTC) #23
timvolodine
On 2017/04/27 15:35:37, jam wrote: > lgtm juncai@: shouldn't //src/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 be updated as well?
3 years, 7 months ago (2017-04-27 15:57:19 UTC) #24
juncai
On 2017/04/27 15:57:19, timvolodine wrote: > On 2017/04/27 15:35:37, jam wrote: > > lgtm > ...
3 years, 7 months ago (2017-04-27 17:15:39 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845763002/80001
3 years, 7 months ago (2017-04-27 22:30:35 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845763002/100001
3 years, 7 months ago (2017-04-28 04:35:24 UTC) #43
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:27:07 UTC) #46
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5a16c1d4606ab4efa34570f1ba36...

Powered by Google App Engine
This is Rietveld 408576698