Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2845653002: Set LayoutParams on TextBubble content view (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set LayoutParams on TextBubble content view On some versions of Android, the LayoutParams aren't set until after the popup window is shown. Explicitly set the LayoutParams to avoid crashing. BUG=713759 Review-Url: https://codereview.chromium.org/2845653002 Cr-Commit-Position: refs/heads/master@{#467337} Committed: https://chromium.googlesource.com/chromium/src/+/ef2a188ba732dd2a75b26909182cea063846c50e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Theresa
ptal
3 years, 8 months ago (2017-04-26 15:34:09 UTC) #3
David Trainor- moved to gerrit
lgtm thanks!
3 years, 8 months ago (2017-04-26 16:04:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845653002/1
3 years, 8 months ago (2017-04-26 16:08:36 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 16:13:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef2a188ba732dd2a75b26909182c...

Powered by Google App Engine
This is Rietveld 408576698