Properly wait for download items in SBNavigationObserverBrowserTests

Properly wait for download items in SBNavigationObserverBrowserTests

This fixes flakiness with PlzNavigate completing navigations before
the download item reaches the UI thread.

BUG=709508
Review-Url: https://codereview.chromium.org/2845593003
Cr-Commit-Position: refs/heads/master@{#467413}
Committed: https://chromium.googlesource.com/chromium/src/+/8865b3ae437986ee8449db0facfd9c1f28d668d5

[Charlie Harrison, 2017-04-26 18:27:44]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:28:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-04-26 18:29:17]

csharrison@chromium.org changed reviewers:
+ jialiul@chromium.org

[Charlie Harrison, 2017-04-26 18:29:18]

jialiul, this fixes flakiness for me locally. Does it make sense to you?

[Jialiu Lin, 2017-04-26 18:30:17]

LGTM. Thanks for fixing these tests!

[Charlie Harrison, 2017-04-26 18:31:50]

The CQ bit was unchecked by csharrison@chromium.org

[Charlie Harrison, 2017-04-26 18:31:50]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2017-04-26 18:32:11]

Not a problem at all, thanks for the speedy review :)

[commit-bot: I haz the power, 2017-04-26 18:32:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 19:35:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493231510498100, "parent_rev":
"6a58846b128bf799fa3cf44a6f30d8b19218560f", "commit_rev":
"8865b3ae437986ee8449db0facfd9c1f28d668d5"}

[commit-bot: I haz the power, 2017-04-26 19:35:43]

Description was changed from

==========
Properly wait for download items in SBNavigationObserverBrowserTests

This fixes flakiness with PlzNavigate completing navigations before
the download item reaches the UI thread.

BUG=709508
==========

to

==========
Properly wait for download items in SBNavigationObserverBrowserTests

This fixes flakiness with PlzNavigate completing navigations before
the download item reaches the UI thread.

BUG=709508

Review-Url: https://codereview.chromium.org/2845593003
Cr-Commit-Position: refs/heads/master@{#467413}
Committed:
https://chromium.googlesource.com/chromium/src/+/8865b3ae437986ee8449db0facfd...
==========

[commit-bot: I haz the power, 2017-04-26 19:35:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8865b3ae437986ee8449db0facfd...