Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view.h

Issue 2845593002: Updates Zoom bubble layout and adds +/- buttons (Closed)
Patch Set: Updates Zoom bubble layout and adds +/- buttons (comments) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/zoom_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.h b/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
index 1d2f2754faa15be9f6d1a83274df8b52af720df5..bcae3abef9f1429a4d8adee78c1d87dea9197262 100644
--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
@@ -20,6 +20,10 @@ namespace content {
class WebContents;
}
+namespace gfx {
+struct VectorIcon;
+}
+
namespace views {
class ImageButton;
} // namespace views
@@ -103,6 +107,13 @@ class ZoomBubbleView : public LocationBarBubbleDelegateView,
// the zoom change.
void SetExtensionInfo(const extensions::Extension* extension);
+ // Creates an ImageButton using vector |icon|, sets a tooltip with
+ // |tooltip_id|. Returns the button.
+ views::Button* CreateZoomButton(const gfx::VectorIcon& icon, int tooltip_id);
+
+ // Updates |label_| with the up to date zoom.
+ void UpdateZoomPercent();
+
// Starts a timer which will close the bubble if |auto_close_| is true.
void StartTimerIfNecessary();
@@ -127,12 +138,20 @@ class ZoomBubbleView : public LocationBarBubbleDelegateView,
// Label displaying the zoom percentage.
views::Label* label_;
+ // Action buttons that can change zoom.
+ views::Button* zoom_out_button_;
+ views::Button* zoom_in_button_;
+ views::Button* reset_button_;
+
// The WebContents for the page whose zoom has changed.
content::WebContents* web_contents_;
// Whether the currently displayed bubble will automatically close.
bool auto_close_;
+ // True when handling a button click event.
+ bool ignore_close_bubble_;
+
// The immersive mode controller for the BrowserView containing
// |web_contents_|.
// Not owned.

Powered by Google App Engine
This is Rietveld 408576698