Updates Zoom bubble layout and adds +/- buttons

chrome/browser/ui/views/location_bar/location_bar_view.cc

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 284f8672adcee772b35cd6d0e4879e2190544d6c..cdd3a9ceae8317228937f8cae052a62b1bb67170 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -320,9 +320,11 @@ void LocationBarView::ZoomChangedForActiveTab(bool can_show_bubble) {
   }
 
   WebContents* web_contents = GetWebContents();
-  if (can_show_bubble && zoom_view_->visible() && web_contents)
+  if (can_show_bubble && web_contents &&
+      (zoom_view_->visible() || ZoomBubbleView::GetZoomBubble())) {

[Peter Kasting, 2017/04/28 05:58:48]

When would GetZoomBubble() be true but |zoom_view_| not be visible?

[varkha, 2017/04/28 06:21:19]

When going over 100% with +/- buttons. Consider that setting zoom to
100% would have hidden the bubble. I block that with the auto-reset var
and then the code below updates the label when the bubble is still
shown.

[Peter Kasting, 2017/04/28 06:47:26]

Hmm.  I'm inclined to say the zoom view should always be visible when the bubble
is visible, even if the bubble is at 100% (or it's not really anchored to
anything in that case).  Then when the bubble disappears, if the zoom level is
100%, the zoom view can go away too.

[varkha, 2017/05/01 10:11:59]

I think this creates more complexity. Consider that for 100% case we would need
an additional icon in location bar (without + or -). Even more confusing is what
should happen when a user opens a zoom bubble, then uses + / - buttons to get
zoom to 100% and then clicks the location bar icon. Presumably the bubble will
close and presumably the icon will get hidden. So we will have a button that
gets
hidden when clicked, probably suboptimal.
Interestingly enough on Mac we now allow the bubble to get through 100% zoom
using + / - buttons and the zoom icon in location bar disappears when zoom is
set
to 100%.

[Peter Kasting, 2017/05/05 23:50:40]

Yes, but I think that's OK, and if the icon is implemented as "magnifier icon
plus optional +/- badge", as is easy in our current system, it wouldn't even be
very difficult to implement.
That's a good case to have pointed out, but I'm not sure it would actually feel
weird as you describe.  Maybe I'm wrong?

It kinda feels weird either way to me.  Being able to have a bubble that doesn't
have an anchor element (with visible "ripple" activation present) is pretty
weird from a Harmony perspective.

I still think doing it the way I suggest would be better, and I still think it
might be worth talking to Hwi about it, but I'm not prepared to block on this. 
Up to you what to do.

If you leave it implemented as it is currently, can we simplify the conditional
to just check GetZoomBubble()?  It seems like that should always be true when
|zoom_view_| is visible so checking that separately feels redundant.  This would
also hopefully avoid the need for much of the comment you added.

     ZoomBubbleView::ShowBubble(web_contents, gfx::Point(),
                                ZoomBubbleView::AUTOMATIC);
+  }
 }
 
 void LocationBarView::SetStarToggled(bool on) {