Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2845543002: Show human readable origin for Android apps (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Show human readable origin for Android apps Prior to this change Android credentials were displayed in a human unfriendly way, e.g. "android://com.nytimes.android/". This change addresses this issue by trying to obtain the affiliated name, while still making clear it is an Android credential. This requires a change to the extensions API. In order to have a user friendly UI three URLs are transmitted from the backend: - origin: This URL comes straight from the password store and contains implementation specific logic. This URL is never surfaced to the user and only serves to do logic such as editing or deleting passwords. - shown: The string that is shown in the UI. It hides the scheme and common host prefixes (e.g. "www") and indicates explicitly if a credential corresponds to an Android app. - link: The URL that is linked from the UI. This is mostly equivalent to origin for Desktop credentials, but differs for Android credentials. If possible, there is a link to an affiliated website, otherwise this contains a link to the PlayStore. BUG=679434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2651663003 Cr-Commit-Position: refs/heads/master@{#466661} (cherry picked from commit f120a871d23619bd90c973bc25b0007ab834c0c1) Review-Url: https://codereview.chromium.org/2845543002 . Cr-Commit-Position: refs/branch-heads/3071@{#220} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/38e6c61012dbcea5d8c640f635b584cc4f67ee1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -143 lines) Patch
M chrome/browser/extensions/api/passwords_private/passwords_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_api.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc View 5 chunks +16 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc View 5 chunks +72 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 10 chunks +17 lines, -17 lines 0 comments Download
M chrome/common/extensions/api/passwords_private.idl View 5 chunks +19 lines, -16 lines 0 comments Download
M chrome/test/data/extensions/api_test/passwords_private/test.js View 5 chunks +20 lines, -8 lines 0 comments Download
M chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/test/data/webui/settings/settings_autofill_section_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/settings_passwords_section_browsertest.js View 9 chunks +13 lines, -14 lines 0 comments Download
M third_party/closure_compiler/externs/passwords_private.js View 5 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdoerrie
3 years, 8 months ago (2017-04-26 08:10:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38e6c61012dbcea5d8c640f635b584cc4f67ee1f.

Powered by Google App Engine
This is Rietveld 408576698