Chromium Code Reviews
DescriptionShow human readable origin for Android apps
Prior to this change Android credentials were displayed in a human
unfriendly way, e.g. "android://com.nytimes.android/". This change
addresses this issue by trying to obtain the affiliated name, while
still making clear it is an Android credential.
This requires a change to the extensions API. In order to have a user
friendly UI three URLs are transmitted from the backend:
- origin: This URL comes straight from the password store and contains
implementation specific logic. This URL is never surfaced to the user
and only serves to do logic such as editing or deleting passwords.
- shown: The string that is shown in the UI. It hides the scheme and
common host prefixes (e.g. "www") and indicates explicitly if a
credential corresponds to an Android app.
- link: The URL that is linked from the UI. This is mostly equivalent to
origin for Desktop credentials, but differs for Android credentials.
If possible, there is a link to an affiliated website, otherwise this
contains a link to the PlayStore.
BUG=679434
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2651663003
Cr-Commit-Position: refs/heads/master@{#466661}
(cherry picked from commit f120a871d23619bd90c973bc25b0007ab834c0c1)
Review-Url: https://codereview.chromium.org/2845543002 .
Cr-Commit-Position: refs/branch-heads/3071@{#220}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/38e6c61012dbcea5d8c640f635b584cc4f67ee1f
Patch Set 1 #Messages
Total messages: 2 (1 generated)
|