Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2845523003: Removes duplicate ui::RegisterPathProvider() (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes duplicate ui::RegisterPathProvider() Both content_main_runner and service_manager were calling ui::RegisterPathProvider(). This removes the call from content_main_runner. BUG=none TEST=none R=rockot@chromium.org,jam@chromium.org TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2845523003 Cr-Commit-Position: refs/heads/master@{#467449} Committed: https://chromium.googlesource.com/chromium/src/+/7b13881ff2eb38bd49925d3595f3ea9fb32def52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/embedder/main.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
3 years, 8 months ago (2017-04-26 19:31:41 UTC) #1
Ken Rockot(use gerrit already)
lgtm
3 years, 8 months ago (2017-04-26 19:32:05 UTC) #3
sky
TBR jam for content change
3 years, 8 months ago (2017-04-26 19:49:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845523003/1
3 years, 8 months ago (2017-04-26 19:50:56 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 20:54:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b13881ff2eb38bd49925d3595f3...

Powered by Google App Engine
This is Rietveld 408576698