Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2845483003:
[User classifier] Adapt the defaults to planned M58 rollout (Closed)
Description[User classifier] Adapt the defaults to planned M58 rollout
This CL adapts the defaults in user classification to the values planned
for the M58 Stable rollout.
BUG=none
Review-Url: https://codereview.chromium.org/2845483003
Cr-Commit-Position: refs/heads/master@{#468615}
Committed: https://chromium.googlesource.com/chromium/src/+/d680636742fdea611199070ab50d18a0e5f7c765
Patch Set 1 #
Total comments: 2
Patch Set 2 : Vitalii's comment #Patch Set 3 : Fix unit-tests #Messages
Total messages: 19 (12 generated)
jkrcal@chromium.org changed reviewers: + vitaliii@chromium.org
Vitalii, could you PTAL?
LGTM % nit. https://codereview.chromium.org/2845483003/diff/1/components/ntp_snippets/use... File components/ntp_snippets/user_classifier.cc (right): https://codereview.chromium.org/2845483003/diff/1/components/ntp_snippets/use... components/ntp_snippets/user_classifier.cc:48: const double kRareUserOpensNTPAtMostOncePerHours = 66; Why 66? It does not look "even". Probably add a comment?
Thanks! https://codereview.chromium.org/2845483003/diff/1/components/ntp_snippets/use... File components/ntp_snippets/user_classifier.cc (right): https://codereview.chromium.org/2845483003/diff/1/components/ntp_snippets/use... components/ntp_snippets/user_classifier.cc:48: const double kRareUserOpensNTPAtMostOncePerHours = 66; On 2017/04/26 14:25:50, vitaliii wrote: > Why 66? It does not look "even". > Probably add a comment? Done.
The CQ bit was checked by jkrcal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vitaliii@chromium.org Link to the patchset: https://codereview.chromium.org/2845483003/#ps20001 (title: "Vitalii's comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jkrcal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vitaliii@chromium.org Link to the patchset: https://codereview.chromium.org/2845483003/#ps40001 (title: "Fix unit-tests")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493730613538140,
"parent_rev": "593fd07de697fbef76e5d7a878546f66118a53b7", "commit_rev":
"d680636742fdea611199070ab50d18a0e5f7c765"}
Message was sent while issue was closed.
Description was changed from ========== [User classifier] Adapt the defaults to planned M58 rollout This CL adapts the defaults in user classification to the values planned for the M58 Stable rollout. BUG=none ========== to ========== [User classifier] Adapt the defaults to planned M58 rollout This CL adapts the defaults in user classification to the values planned for the M58 Stable rollout. BUG=none Review-Url: https://codereview.chromium.org/2845483003 Cr-Commit-Position: refs/heads/master@{#468615} Committed: https://chromium.googlesource.com/chromium/src/+/d680636742fdea611199070ab50d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d680636742fdea611199070ab50d... |
