Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ios/chrome/browser/ui/activity_services/README.md

Issue 2845483002: Add README with info on how to add iOS Password Managers. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/activity_services/README.md
diff --git a/ios/chrome/browser/ui/activity_services/README.md b/ios/chrome/browser/ui/activity_services/README.md
new file mode 100644
index 0000000000000000000000000000000000000000..54ba96efe61d5361ff785ab7eae3941137e3bd7f
--- /dev/null
+++ b/ios/chrome/browser/ui/activity_services/README.md
@@ -0,0 +1,34 @@
+# iOS Application Specific Services in Chrome for iOS
+
+[UIActivity][1] is an abstract class for implementing app-specific services
+such as Share (to social media), Print, Reading List, and Password Management
+app extensions.
+
+## Adding iOS Password Managers App Extensions
+
+Chrome for iOS recognizes an action extension is a Password Manager app
+extension in one of the following two ways.
+
+1. By Bundle ID match. If the bundle ID for the app extension contains
+the substring `find-login-action`, it will be handled as a Password
+Manager app extension.
+
+1. By explicitly listing in [`activity_type_util.mm`][2]. The anonymous
+namespace function `IsPasswordManagerActivity()` in this file contains
+a static structure listing all the Password Manager app extensions
+known to Chrome for iOS. The first field is a string containing either
+the full bundle ID or the leading portion of the bundle ID. The second
+field is a flag to indicate whether a full bundle ID is expected or
+if the string is intended to be a prefix for matching bundle IDs.
+
+The first option is recommended because it does not require any code
+changes to Chrome. If an app extension meets the first condition, it
+works with current and previous versions of Chrome for iOS (since early
+2016). If for any reasons that an app extension cannot change its
+bundle ID, option 2 may be used. To add support to Chrome for iOS, submit
+a changelist similar to [this][3] for review.
+
+
+[1]: https://developer.apple.com/reference/uikit/uiactivity?language=objc
+[2]: ./activity_type_util.mm
+[3]: https://codereview.chromium.org/2820113002/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698