Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2845463004: [webnfc] Handle IllegalStateException during read / write operations (Closed)

Created:
3 years, 7 months ago by shalamov
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Handle IllegalStateException during read / write operations Accodring to Android documentation [1] read and write operations for Ndef technology, should not throw IllegalStateException, however, those operations do throw exception that must be handled. Unit tests are updated to check that exception is handled and correct error reported to caller. [1] https://developer.android.com/reference/android/nfc/tech/Ndef.html BUG=714039 Review-Url: https://codereview.chromium.org/2845463004 Cr-Commit-Position: refs/heads/master@{#467610} Committed: https://chromium.googlesource.com/chromium/src/+/2dd2610dc05678f182b268412a63150b5fd8eacb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -10 lines) Patch
M device/nfc/android/java/src/org/chromium/device/nfc/NfcImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M device/nfc/android/java/src/org/chromium/device/nfc/NfcTagHandler.java View 4 chunks +12 lines, -8 lines 0 comments Download
M device/nfc/android/junit/src/org/chromium/device/nfc/NFCTest.java View 3 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
shalamov
Could you please take a look.
3 years, 7 months ago (2017-04-26 13:17:16 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 7 months ago (2017-04-26 17:12:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845463004/1
3 years, 7 months ago (2017-04-27 06:51:48 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 06:55:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2dd2610dc05678f182b268412a63...

Powered by Google App Engine
This is Rietveld 408576698