Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2845433003: [EasyUnlock] Update ProximityMonitor to only check for RSSI proximity. (Closed)

Created:
3 years, 8 months ago by Tim Song
Modified:
3 years, 7 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, chromium-apps-reviews_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Update ProximityMonitor to only check for RSSI proximity. This CL also changes UnlockManager to use the new interface for ProximityMonitor. Review-Url: https://codereview.chromium.org/2845433003 Cr-Commit-Position: refs/heads/master@{#467860} Committed: https://chromium.googlesource.com/chromium/src/+/bfabbfb6a32d7f654aad1ab45f5d233445db1b21

Patch Set 1 : [EasyUnlock] Update ProximityMonitor to only check for RSSI proximity. #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -591 lines) Patch
M components/proximity_auth/fake_remote_device_life_cycle.h View 4 chunks +8 lines, -0 lines 0 comments Download
M components/proximity_auth/fake_remote_device_life_cycle.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/proximity_auth/messenger.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/proximity_auth/messenger_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/messenger_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/proximity_auth/proximity_monitor.h View 2 chunks +0 lines, -10 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.h View 1 6 chunks +7 lines, -42 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.cc View 1 9 chunks +18 lines, -91 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl_unittest.cc View 1 12 chunks +61 lines, -272 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M components/proximity_auth/unlock_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/unlock_manager_impl.cc View 7 chunks +12 lines, -24 lines 0 comments Download
M components/proximity_auth/unlock_manager_impl_unittest.cc View 1 28 chunks +81 lines, -150 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Tim Song
3 years, 8 months ago (2017-04-26 18:13:38 UTC) #6
sacomoto
LGTM. https://codereview.chromium.org/2845433003/diff/60001/components/proximity_auth/proximity_monitor_impl.h File components/proximity_auth/proximity_monitor_impl.h (right): https://codereview.chromium.org/2845433003/diff/60001/components/proximity_auth/proximity_monitor_impl.h#newcode115 components/proximity_auth/proximity_monitor_impl.h:115: std::unique_ptr<base::TimeTicks> last_zero_rssi_timestamp_; This is not relevant anymore, right? ...
3 years, 7 months ago (2017-04-27 20:10:03 UTC) #7
Tim Song
https://codereview.chromium.org/2845433003/diff/60001/components/proximity_auth/proximity_monitor_impl.h File components/proximity_auth/proximity_monitor_impl.h (right): https://codereview.chromium.org/2845433003/diff/60001/components/proximity_auth/proximity_monitor_impl.h#newcode115 components/proximity_auth/proximity_monitor_impl.h:115: std::unique_ptr<base::TimeTicks> last_zero_rssi_timestamp_; On 2017/04/27 20:10:03, sacomoto wrote: > This ...
3 years, 7 months ago (2017-04-28 00:27:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845433003/80001
3 years, 7 months ago (2017-04-28 01:40:31 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 02:58:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bfabbfb6a32d7f654aad1ab45f5d...

Powered by Google App Engine
This is Rietveld 408576698