Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2845393002: Disable TransferCookiesUnaffiliated test under Debug (Closed)

Created:
3 years, 7 months ago by emaxx
Modified:
3 years, 7 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TransferCookiesUnaffiliated test under Debug The SAMLPolicyTest.TransferCookiesUnaffiliated test and its PRE-test were timing out in Debug builds. There is nothing obvious that can be improved in the test. Also the timeout times agree to some degree with the slowdown of the Debug mode measured locally. Therefore disabling this test in Debug builds. BUG=683161, 714167 Review-Url: https://codereview.chromium.org/2845393002 Cr-Commit-Position: refs/heads/master@{#468452} Committed: https://chromium.googlesource.com/chromium/src/+/d13854ee9bf02222c3a67552f9fa1875ed6e969e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
emaxx
alemate@: PTAL.
3 years, 7 months ago (2017-04-28 16:12:06 UTC) #3
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-01 20:42:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845393002/1
3 years, 7 months ago (2017-05-01 21:38:44 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:19:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d13854ee9bf02222c3a67552f9fa...

Powered by Google App Engine
This is Rietveld 408576698