Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2845373003: Remove @color/appbar_background (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove @color/appbar_background appbar_background was previously used to provide a grey toolbar on phones and a white toolbar on tablets for the downloads and bookmarks UIs. The toolbar for these UIs is always gray now, so appbar_background is no longer needed. BUG=687640 Review-Url: https://codereview.chromium.org/2845373003 Cr-Commit-Position: refs/heads/master@{#468054} Committed: https://chromium.googlesource.com/chromium/src/+/f86b28ba2b600f3bfce7f1190c1ca0d01a68b9f9

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 7 months ago (2017-04-28 16:52:56 UTC) #3
mdjones
lgtm
3 years, 7 months ago (2017-04-28 17:12:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845373003/1
3 years, 7 months ago (2017-04-28 17:48:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:57:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f86b28ba2b600f3bfce7f1190c1c...

Powered by Google App Engine
This is Rietveld 408576698