Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2845363003: Check for learn-more-link before clicking details (Closed)

Created:
3 years, 7 months ago by Nate Fischer
Modified:
3 years, 7 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for learn-more-link before clicking details The "learn more" link has moved to the main content instead of the details. Tests should check for it before clicking the details, since mobile layouts will hide the main content after "details" is clicked. BUG=674732 Review-Url: https://codereview.chromium.org/2845363003 Cr-Commit-Position: refs/heads/master@{#468073} Committed: https://chromium.googlesource.com/chromium/src/+/80ca9270c0de1eb57260a76d1d91caecf6bfc47e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Nate Fischer
PTAL. This change is cherry picked from crrev/2848733002. It's orthogonal to the real change in ...
3 years, 7 months ago (2017-04-28 17:22:04 UTC) #4
Jialiu Lin
lgtm
3 years, 7 months ago (2017-04-28 17:43:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845363003/1
3 years, 7 months ago (2017-04-28 18:28:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:43:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80ca9270c0de1eb57260a76d1d91...

Powered by Google App Engine
This is Rietveld 408576698