Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Issue 2845333003: Better error handling for FFmpegDemuxer seeking

Created:
3 years, 7 months ago by servolk
Modified:
3 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Better error handling for FFmpegDemuxer seeking BUG=23447, 709302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M media/filters/ffmpeg_demuxer.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
servolk
On 2017/04/29 00:11:22, servolk wrote: > Description was changed from > > ========== > Better ...
3 years, 7 months ago (2017-04-29 00:14:13 UTC) #4
DaleCurtis
Looks like bots are failing, so we have test clip after all?? :)
3 years, 7 months ago (2017-05-01 22:58:42 UTC) #8
servolk
3 years, 7 months ago (2017-05-01 23:02:13 UTC) #9
On 2017/05/01 22:58:42, DaleCurtis wrote:
> Looks like bots are failing, so we have  test clip after all?? :)

Yes, although it looks like failures are only in AudioBearFlac test, which was
added only recently. That TODO about seeking errors not being handled properly
is way older than FLAC support. Anyway, I'll try to debug to understand why the
seeking fails in those FLAC streams.

Powered by Google App Engine
This is Rietveld 408576698