Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: media/filters/ffmpeg_demuxer.cc

Issue 2845333003: Better error handling for FFmpegDemuxer seeking
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer.cc
diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc
index 081bcbf1a452be23ee45adb6a080e11bd5b55c77..5b7010786aacb32b99eb7f6dfd9889f511f1d9c9 100644
--- a/media/filters/ffmpeg_demuxer.cc
+++ b/media/filters/ffmpeg_demuxer.cc
@@ -1649,10 +1649,10 @@ void FFmpegDemuxer::OnSeekFrameDone(int result) {
}
if (result < 0) {
- // Use VLOG(1) instead of NOTIMPLEMENTED() to prevent the message being
- // captured from stdout and contaminates testing.
- // TODO(scherkus): Implement this properly and signal error (BUG=23447).
- VLOG(1) << "Not implemented";
+ MEDIA_LOG(ERROR, media_log_)
+ << GetDisplayName() << ": seek failed: " << AVErrorToString(result);
+ base::ResetAndReturn(&pending_seek_cb_).Run(PIPELINE_ERROR_ABORT);
+ return;
}
// Tell streams to flush buffers due to seeking.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698