Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2845293004: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, David Trainor- moved to gerrit, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2845293004 Cr-Commit-Position: refs/heads/master@{#468226} Committed: https://chromium.googlesource.com/chromium/src/+/00f09058b11938a3dfc685e1ae41f4019241b215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_danger_prompt_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/download_history.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_item_model.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_status_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_status_updater_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:22:26 UTC) #4
qinmin
lgtm
3 years, 7 months ago (2017-04-29 04:52:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845293004/1
3 years, 7 months ago (2017-04-29 04:54:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 04:59:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00f09058b11938a3dfc685e1ae41...

Powered by Google App Engine
This is Rietveld 408576698