Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2845263002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, gavinp+prer_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2845263002 Cr-Commit-Position: refs/heads/master@{#468031} Committed: https://chromium.googlesource.com/chromium/src/+/509a04187b65fc65c561d81af3ee3ede268584f3

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-28 03:39:12 UTC) #6
ncarter (slow)
lgtm
3 years, 7 months ago (2017-04-28 16:57:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845263002/1
3 years, 7 months ago (2017-04-28 16:57:34 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:04:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/509a04187b65fc65c561d81af3ee...

Powered by Google App Engine
This is Rietveld 408576698