Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2845253002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, jam, ios-reviews+web_chromium.org, darin-cc_chromium.org, Eugene But (OOO till 7-30), ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2845253002 Cr-Commit-Position: refs/heads/master@{#468014} Committed: https://chromium.googlesource.com/chromium/src/+/d6d85694bda0d4eb0a9ca014e0c0ab851d95fff3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M components/favicon/content/content_favicon_driver.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/favicon/content/content_favicon_driver.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/favicon/ios/web_favicon_driver.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/favicon/ios/web_favicon_driver.mm View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-28 03:38:38 UTC) #6
stevenjb
RS owner lgtm
3 years, 7 months ago (2017-04-28 15:39:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845253002/1
3 years, 7 months ago (2017-04-28 15:42:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 15:49:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6d85694bda0d4eb0a9ca014e0c0...

Powered by Google App Engine
This is Rietveld 408576698