Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2845223003: [Merge m59] Only whitelist messages.json files in _locales for content verification (Closed)

Created:
3 years, 7 months ago by lazyboy
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge m59] Only whitelist messages.json files in _locales for content verification The messages.json files used for i18n/l10n get transcoded during the extension install process, so we need to avoid doing content verification checks on them because we expect their contents to be modified. The code we had for testing whether a path should be skipped because of this was incorrect, skipping more files than it should. Through the courtesy of Antony: https://crrev.com/2572833004 The CL also renames some path variables in content verification code to stress that they contain unix style '/' separators. BUG=672008 Review-Url: https://codereview.chromium.org/2834873002 Cr-Commit-Position: refs/heads/master@{#466769} (cherry picked from commit d05d1e844e7d376400a7437989c4c50a5875b36f) Review-Url: https://codereview.chromium.org/2845223003 . Cr-Commit-Position: refs/branch-heads/3071@{#302} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/503cfcd789d2d9769c2e1a6a1fe53b7be00c59ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -97 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 2 chunks +52 lines, -40 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/content_script_locales.crx View Binary file 0 comments Download
M extensions/browser/content_hash_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 5 chunks +16 lines, -17 lines 0 comments Download
M extensions/browser/content_verifier.h View 1 chunk +13 lines, -11 lines 0 comments Download
M extensions/browser/content_verifier.cc View 5 chunks +26 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lazyboy
3 years, 7 months ago (2017-04-28 20:40:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
503cfcd789d2d9769c2e1a6a1fe53b7be00c59ce.

Powered by Google App Engine
This is Rietveld 408576698