Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2845223002: Fix transfers for data URLs with plugin mime types. (Closed)

Created:
3 years, 7 months ago by Charlie Reis
Modified:
3 years, 7 months ago
Reviewers:
alexmos
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix transfers for data URLs with plugin mime types. Typically, when a local frame navigates to a data URL, the request is serviced in the renderer without going up to the browser process. However, this isn't true for some data URLs, such as those with plugin mime types. Those go up to the browser, where they stalled due to conflicting logic that first decided that a transfer is needed, marked the current RFH as transferring, but then decided that a process transfer isn't allowed and kept the load in the current RFH. When the process transfer is prevented by CanSubframeSwapProcess, the load will always stay in the current RFH. This CL tries to recognize scenarios where this happens for transfers that also starts in the current RFH, so that we can avoid calling Transfer() for the current RFH unnecessarily. BUG=697513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2729523003 Cr-Commit-Position: refs/heads/master@{#455821} (cherry picked from commit 71e8d307789f1cf492f4803bdceab898e8105a47) Review-Url: https://codereview.chromium.org/2845223002 . Cr-Commit-Position: refs/branch-heads/3029@{#781} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/0454f5814f0bcd28398d93ec6700fc34adae20a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 3 chunks +23 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Charlie Reis
FYI: Merging to M58.
3 years, 7 months ago (2017-04-28 17:16:51 UTC) #2
Charlie Reis
3 years, 7 months ago (2017-04-28 17:17:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0454f5814f0bcd28398d93ec6700fc34adae20a0.

Powered by Google App Engine
This is Rietveld 408576698