Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2845173003: [Sync] Enable AndroidSyncSettingsTest (Closed)

Created:
3 years, 7 months ago by pavely
Modified:
3 years, 7 months ago
Reviewers:
Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Enable AndroidSyncSettingsTest I think original issue was caused by ChromeApplication.onCreate calling AccountManagerHelper.initializeAccountManagerHelper and discovering instance of AccountManagerHelper that was set up by test. This issue is addressed by http://crrev.com/2836373003. Another issue was that waiting for syncability propagation to ContentResolver got broken by refactoring http://crrev.com/2778443002. This issue was addressed by change http://crrev.com/2847663003. Seems like after these changes test should be passing. I ran it in a loop for 1000 iterations and it passed so I'm enabling the test. BUG=605567 R=pnoland@chromium.org Review-Url: https://codereview.chromium.org/2845173003 Cr-Commit-Position: refs/heads/master@{#468098} Committed: https://chromium.googlesource.com/chromium/src/+/20c0b3059ef47f07a3e09e40f1dcc167da4817d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pavely
3 years, 7 months ago (2017-04-27 23:30:16 UTC) #1
Patrick Noland
lgtm
3 years, 7 months ago (2017-04-27 23:40:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845173003/1
3 years, 7 months ago (2017-04-28 18:28:28 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 19:50:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20c0b3059ef47f07a3e09e40f1dc...

Powered by Google App Engine
This is Rietveld 408576698