Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2845173002: [Chromecast] Fix CastMediaClient::IsSupportedAudioConfig() for (E)AC3 on Android (Closed)

Created:
3 years, 7 months ago by AndyWu
Modified:
3 years, 7 months ago
Reviewers:
servolk, halliwell, Simeon
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix CastMediaClient::IsSupportedAudioConfig() for (E)AC3 on Android Before we have the chance to fully implement the function, we need a quick fix for (E)AC3. No ATV we know of that supports (E)AC3 decoder, so it relies on the audio sink device. BUG=Internal b/36896359 Review-Url: https://codereview.chromium.org/2845173002 Cr-Commit-Position: refs/heads/master@{#467784} Committed: https://chromium.googlesource.com/chromium/src/+/d0e6a4dc1cf50fbc387786abbb2379a2b2066aff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
AndyWu
The previous change in chromecast/common/media/cast_media_client.cc was wiped out; need to reimplement it again in chromecast/renderer/cast_content_renderer_client.cc.
3 years, 7 months ago (2017-04-27 18:19:30 UTC) #3
Simeon
On 2017/04/27 18:19:30, AndyWu wrote: > The previous change in chromecast/common/media/cast_media_client.cc was wiped > out; ...
3 years, 7 months ago (2017-04-27 18:22:03 UTC) #4
halliwell
On 2017/04/27 18:22:03, Simeon wrote: > On 2017/04/27 18:19:30, AndyWu wrote: > > The previous ...
3 years, 7 months ago (2017-04-27 19:22:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845173002/1
3 years, 7 months ago (2017-04-27 19:59:43 UTC) #7
servolk
On 2017/04/27 19:59:43, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 7 months ago (2017-04-27 20:02:08 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:50:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0e6a4dc1cf50fbc387786abbb23...

Powered by Google App Engine
This is Rietveld 408576698