Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2845163002:
Remove collecting data on max memory pages for asm.js, not applicable. (Closed)
DescriptionRemove collecting data on max memory pages for asm.js, not applicable.
Only WASM has the notion of changing the maximum memory pages. This
CL corrects the UMA stats to only collect this data for WASM only.
BUG=v8:6321
R=bradnelson@chromium.org,bbudge@chromium.org
Review-Url: https://codereview.chromium.org/2845163002
Cr-Commit-Position: refs/heads/master@{#44988}
Committed: https://chromium.googlesource.com/v8/v8/+/7e4282d5031cbf9f596747cd4db84c740a2b93c9
Patch Set 1 #
Messages
Total messages: 21 (17 generated)
Description was changed from ========== Remove collecting data on max memory pages for asm.js, not applicable. Only WASM has the notion of changing the maximum memory pages. This CL corrects the UMA stats to only collect this data for WASM only. BUG= ========== to ========== Remove collecting data on max memory pages for asm.js, not applicable. Only WASM has the notion of changing the maximum memory pages. This CL corrects the UMA stats to only collect this data for WASM only. BUG=v8:6321 R=bradnelson@chromium.org,bbudge@chromium.org ==========
kschimpf@chromium.org changed reviewers: + bbudge@chromium.org, bradnelson@chromium.org
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Please review. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
lgtm once you fix the build
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
The CQ bit was checked by kschimpf@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kschimpf@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493394319942240, "parent_rev":
"b05ddffb377a2c3ed217582f2b5cbdb6432d97bf", "commit_rev":
"7e4282d5031cbf9f596747cd4db84c740a2b93c9"}
Message was sent while issue was closed.
Description was changed from ========== Remove collecting data on max memory pages for asm.js, not applicable. Only WASM has the notion of changing the maximum memory pages. This CL corrects the UMA stats to only collect this data for WASM only. BUG=v8:6321 R=bradnelson@chromium.org,bbudge@chromium.org ========== to ========== Remove collecting data on max memory pages for asm.js, not applicable. Only WASM has the notion of changing the maximum memory pages. This CL corrects the UMA stats to only collect this data for WASM only. BUG=v8:6321 R=bradnelson@chromium.org,bbudge@chromium.org Review-Url: https://codereview.chromium.org/2845163002 Cr-Commit-Position: refs/heads/master@{#44988} Committed: https://chromium.googlesource.com/v8/v8/+/7e4282d5031cbf9f596747cd4db84c740a2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/7e4282d5031cbf9f596747cd4db84c740a2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
