Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2845153002: [string] Fix null handling in MaybeCallFunctionAtSymbol (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[string] Fix null handling in MaybeCallFunctionAtSymbol The spec requires that a null @@split / @@replace symbol is treated exactly the same as if it were undefined, i.e. execution should move on to the default implementation instead of throwing a TypeError. BUG=v8:6313 Review-Url: https://codereview.chromium.org/2845153002 Cr-Commit-Position: refs/heads/master@{#44959} Committed: https://chromium.googlesource.com/v8/v8/+/281488547744d3341cd9c1d92489696420ee63c1

Patch Set 1 #

Patch Set 2 : Clarify comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/builtins/builtins-string-gen.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M test/mjsunit/es6/string-replace.js View 2 chunks +5 lines, -1 line 0 comments Download
M test/mjsunit/es6/string-split.js View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
jgruber
ptal
3 years, 7 months ago (2017-04-27 16:35:03 UTC) #4
Benedikt Meurer
LGTM, thanks!
3 years, 7 months ago (2017-04-27 16:47:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845153002/20001
3 years, 7 months ago (2017-04-28 05:57:02 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:58:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/281488547744d3341cd9c1d92489696420e...

Powered by Google App Engine
This is Rietveld 408576698