Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 2845143002: cc: Allow changing mask type when pushing properties. (Closed)

Created:
3 years, 7 months ago by sunxd
Modified:
3 years, 7 months ago
Reviewers:
danakj, trchen, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Allow changing mask type when pushing properties. With mask tiling, it is possible that a tiled mask gets a filter after tiles are created. In order to make picture layer tilings throw away tiles, we need to change the mask type from MULTI_TEXTURE_MASK to SINGLE_TEXTURE_MASK, but mask type was set to be immutable as we do not allow NOT_MASK to MASK conversion and vice versa. This CL attempts to fix the demoting problem by making mask type a non- const value and prevent NOT_MASK to MASK conversion by DCHECK. BUG=567293 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2845143002 Cr-Commit-Position: refs/heads/master@{#468094} Committed: https://chromium.googlesource.com/chromium/src/+/2118ed449481692d624823e64c345f2990cec478

Patch Set 1 #

Patch Set 2 : Disable mask tiling. #

Total comments: 2

Patch Set 3 : Add comment to SetLayerMaskType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M cc/layers/picture_layer.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
sunxd
PTAL. This is an attempt to fix the demoting issue. I understand that we want ...
3 years, 7 months ago (2017-04-27 14:57:03 UTC) #5
sunxd
PTAL. I disabled mask tiling again as the layout tests are completed with expected minor ...
3 years, 7 months ago (2017-04-28 16:32:14 UTC) #10
enne (OOO)
lgtm I think your description has switched multi and single? Adding a filter should make ...
3 years, 7 months ago (2017-04-28 17:08:30 UTC) #11
sunxd
https://codereview.chromium.org/2845143002/diff/20001/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/2845143002/diff/20001/cc/layers/picture_layer_impl.cc#newcode126 cc/layers/picture_layer_impl.cc:126: DCHECK(mask_type_ != Layer::LayerMaskType::NOT_MASK && On 2017/04/28 17:08:30, enne wrote: ...
3 years, 7 months ago (2017-04-28 17:53:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845143002/40001
3 years, 7 months ago (2017-04-28 17:54:35 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 19:36:42 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2118ed449481692d624823e64c34...

Powered by Google App Engine
This is Rietveld 408576698