Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2845123002: [runtime] Support proxies as return value of API constructors. (Closed)

Created:
3 years, 7 months ago by neis
Modified:
3 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Support proxies as return value of API constructors. When a FunctionTemplate-based function is used as a constructor and returns a JSProxy, we incorrectly treated that result the same as a non-object result. Now it is treated like any other object result, i.e., it becomes the result of the constructor call. R=verwaest@chromium.org BUG=v8:6294 Review-Url: https://codereview.chromium.org/2845123002 Cr-Commit-Position: refs/heads/master@{#44970} Committed: https://chromium.googlesource.com/v8/v8/+/9bfb0fef08a4170899a44487911c0dc78b4985e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -22 lines) Patch
M src/builtins/builtins-api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +52 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
neis
3 years, 7 months ago (2017-04-27 14:15:41 UTC) #1
Toon Verwaest
lgtm
3 years, 7 months ago (2017-04-28 09:16:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845123002/1
3 years, 7 months ago (2017-04-28 09:30:10 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 10:02:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9bfb0fef08a4170899a44487911c0dc78b4...

Powered by Google App Engine
This is Rietveld 408576698