Rename MockAccountManager to FakeAccountManagerDelegate

Rename MockAccountManager to FakeAccountManagerDelegate

This CL makes several minor changes to MockAccountManager:
1. Add 'Delegate' to the name, because it implements AccountManagerDelegate and
   should be used with AccountManagerHelper.
2. Replace 'Mock' with 'Fake' in the name.
3. Remove redundant testContext from constructor arguments.

BUG=698258
Review-Url: https://codereview.chromium.org/2845113003
Cr-Commit-Position: refs/heads/master@{#467942}
Committed: https://chromium.googlesource.com/chromium/src/+/be15d305d316ac95dbc70a3dadb1bad9e3430eff

[bsazonov, 2017-04-27 13:59:02]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 13:59:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsazonov, 2017-04-27 14:04:37]

bsazonov@chromium.org changed reviewers:
+ msarda@chromium.org, nyquist@chromium.org

[bsazonov, 2017-04-27 14:04:38]

Mihai, please review changes in components/signin.
Tommy, please review changes in chrome and components/sync.

[msarda, 2017-04-27 14:28:34]

components/signin changes LGTM.

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java
(right):

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java:29:
mAccountManager = new FakeAccountManagerDelegate(context);
Nit: s/mAccountManager/mDelegate

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java
(right):

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java:110:
"Created new auth token for " + ah.getAccount() + ": authTokenScope = "
This indent seems wrong (however I will not pretend I know the Java styleguide,
so maybe it is correct). Is this something generated by "git cl format"?

[bsazonov, 2017-04-27 15:17:54]

Mihai, thanks for the prompt review.

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java
(right):

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java:29:
mAccountManager = new FakeAccountManagerDelegate(context);
On 2017/04/27 14:28:34, msarda wrote:
> Nit: s/mAccountManager/mDelegate

Done.

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java
(right):

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java:110:
"Created new auth token for " + ah.getAccount() + ": authTokenScope = "
On 2017/04/27 14:28:34, msarda wrote:
> This indent seems wrong (however I will not pretend I know the Java
styleguide,
> so maybe it is correct). Is this something generated by "git cl format"?

Yes, this was actually generated by 'git cl format'. Should I align it manually?

[bsazonov, 2017-04-27 15:21:45]

Patchset #2 (id:20001) has been deleted

[bsazonov, 2017-04-27 15:22:58]

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java
(right):

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java:110:
"Created new auth token for " + ah.getAccount() + ": authTokenScope = "
On 2017/04/27 15:17:54, bsazonov wrote:
> On 2017/04/27 14:28:34, msarda wrote:
> > This indent seems wrong (however I will not pretend I know the Java
> styleguide,
> > so maybe it is correct). Is this something generated by "git cl format"?
> 
> Yes, this was actually generated by 'git cl format'. Should I align it
manually?

I've changed the wrapping of the string parts to avoid this issue.

[bsazonov, 2017-04-27 15:28:28]

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java
(right):

https://codereview.chromium.org/2845113003/diff/1/components/signin/core/brow...
components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java:110:
"Created new auth token for " + ah.getAccount() + ": authTokenScope = "
On 2017/04/27 15:22:58, bsazonov wrote:
> On 2017/04/27 15:17:54, bsazonov wrote:
> > On 2017/04/27 14:28:34, msarda wrote:
> > > This indent seems wrong (however I will not pretend I know the Java
> > styleguide,
> > > so maybe it is correct). Is this something generated by "git cl format"?
> > 
> > Yes, this was actually generated by 'git cl format'. Should I align it
> manually?
> 
> I've changed the wrapping of the string parts to avoid this issue.

Nevermind, 'git cl format' reverts my changes, so it looks like there's no way
to avoid this

[nyquist, 2017-04-27 22:02:37]

lgtm

[bsazonov, 2017-04-28 08:19:20]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-04-28 08:19:20]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2845113003/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-28 08:19:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 09:29:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493367560450290,
"parent_rev": "93c0e26115af080b07623c0588c6ba1cfa5a552a", "commit_rev":
"be15d305d316ac95dbc70a3dadb1bad9e3430eff"}

[commit-bot: I haz the power, 2017-04-28 09:30:04]

Description was changed from

==========
Rename MockAccountManager to FakeAccountManagerDelegate

This CL makes several minor changes to MockAccountManager:
1. Add 'Delegate' to the name, because it implements AccountManagerDelegate and
   should be used with AccountManagerHelper.
2. Replace 'Mock' with 'Fake' in the name.
3. Remove redundant testContext from constructor arguments.

BUG=698258
==========

to

==========
Rename MockAccountManager to FakeAccountManagerDelegate

This CL makes several minor changes to MockAccountManager:
1. Add 'Delegate' to the name, because it implements AccountManagerDelegate and
   should be used with AccountManagerHelper.
2. Replace 'Mock' with 'Fake' in the name.
3. Remove redundant testContext from constructor arguments.

BUG=698258

Review-Url: https://codereview.chromium.org/2845113003
Cr-Commit-Position: refs/heads/master@{#467942}
Committed:
https://chromium.googlesource.com/chromium/src/+/be15d305d316ac95dbc70a3dadb1...
==========

[commit-bot: I haz the power, 2017-04-28 09:30:05]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/be15d305d316ac95dbc70a3dadb1...