chrome/browser/ui/webui/chromeos/network_ui.cc - Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/network_ui.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/network_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/network_ui.cc b/chrome/browser/ui/webui/chromeos/network_ui.cc

index ac5352e47210a9b485d21fd50142626bb32e126c..5cdb9f79d4072e2ba2a6a918e17011ef882f36e3 100644

--- a/chrome/browser/ui/webui/chromeos/network_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/network_ui.cc

@@ -64,7 +64,7 @@ void SetDeviceProperties(base::DictionaryValue* dictionary) {

ip_configs->Append(iter.value().CreateDeepCopy());

}

device_dictionary->SetWithoutPathExpansion(shill::kIPConfigsProperty,

- ip_configs.release());

+ std::move(ip_configs));

}

if (!device_dictionary->empty())

dictionary->Set(shill::kDeviceProperty, std::move(device_dictionary));