chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc - Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

index 95d9805b32ae8781bd2a84dc64dfab4ae8a23c07..7651f052ee27bbd9429aff6fa5c3df24ac66be99 100644

--- a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

+++ b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc

@@ -273,7 +273,7 @@ void KioskAppsHandler::SendKioskAppSettings() {

PopulateAppDict(app_data, app_info.get());

apps_list->Append(std::move(app_info));

}

- settings.SetWithoutPathExpansion("apps", apps_list.release());

+ settings.SetWithoutPathExpansion("apps", std::move(apps_list));

web_ui()->CallJavascriptFunctionUnsafe(

"extensions.KioskAppsOverlay.setSettings", settings);