Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3556)

Unified Diff: chrome/test/chromedriver/chrome/log.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/log.cc
diff --git a/chrome/test/chromedriver/chrome/log.cc b/chrome/test/chromedriver/chrome/log.cc
index 93024c02e88ccb1f2cb7e1244c0e26247381383a..c428aabb1854ae2520ada25df81dd9aae7074a56 100644
--- a/chrome/test/chromedriver/chrome/log.cc
+++ b/chrome/test/chromedriver/chrome/log.cc
@@ -53,8 +53,7 @@ std::unique_ptr<base::Value> SmartDeepCopy(const base::Value* value) {
}
const base::Value* child = NULL;
dict->GetWithoutPathExpansion(it.key(), &child);
- dict_copy->SetWithoutPathExpansion(it.key(),
- SmartDeepCopy(child).release());
+ dict_copy->SetWithoutPathExpansion(it.key(), SmartDeepCopy(child));
}
return std::move(dict_copy);
} else if (value->GetAsList(&list)) {

Powered by Google App Engine
This is Rietveld 408576698