Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5676)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/supervised_user/supervised_user_settings_service.cc ('K') | « chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc ('k') | chrome/browser/ui/webui/chromeos/network_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc b/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
index 3bae474ca267dbc62251c524b32294e20a277cd8..d8b87c62e05583048ba2894f5a896f40253e6c3a 100644
--- a/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
@@ -79,7 +79,7 @@ void BaseWebUIHandler::ShowScreenWithData(OobeScreen screen,
base::DictionaryValue screen_params;
screen_params.SetString("id", GetOobeScreenName(screen));
if (data)
- screen_params.SetWithoutPathExpansion("data", data->DeepCopy());
+ screen_params.SetWithoutPathExpansion("data", data->CreateDeepCopy());
vabr (Chromium) 2017/04/28 07:23:40 and here a copy constructor as well
jdoerrie 2017/05/02 18:08:06 Done.
web_ui()->CallJavascriptFunctionUnsafe("cr.ui.Oobe.showScreen",
screen_params);
}
« chrome/browser/supervised_user/supervised_user_settings_service.cc ('K') | « chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc ('k') | chrome/browser/ui/webui/chromeos/network_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698