Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

Issue 2845113002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chrome (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
index 0c2e812e905712e7e34a4ad15360222534e0e39b..0eb0003ee009540dc588f399d4da57e61fdbd74a 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
@@ -71,8 +71,9 @@ class ScopedArcPrefUpdate : public DictionaryPrefUpdate {
base::DictionaryValue* dict = DictionaryPrefUpdate::Get();
base::DictionaryValue* dict_item = nullptr;
if (!dict->GetDictionaryWithoutPathExpansion(id_, &dict_item)) {
- dict_item = new base::DictionaryValue();
- dict->SetWithoutPathExpansion(id_, dict_item);
+ dict->SetWithoutPathExpansion(id_,
+ base::MakeUnique<base::DictionaryValue>());
+ dict->GetDictionaryWithoutPathExpansion(id_, &dict_item);
}
return dict_item;
}

Powered by Google App Engine
This is Rietveld 408576698