Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2845103002: predictors: Remove ResourcePrefetchPredictorConfig from ResourcePrefetcher. (Closed)

Created:
3 years, 7 months ago by Benoit L
Modified:
3 years, 7 months ago
Reviewers:
alexilin
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Remove ResourcePrefetchPredictorConfig from ResourcePrefetcher. The object is quite large, this class doesn't need to know about it. This is intended to ease refactoring. BUG=715525 Review-Url: https://codereview.chromium.org/2845103002 Cr-Commit-Position: refs/heads/master@{#467717} Committed: https://chromium.googlesource.com/chromium/src/+/1bf0b01f2d03b3d805a9dbf2ecb97b9bda3e5a79

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -27 lines) Patch
M chrome/browser/predictors/resource_prefetcher.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_manager.cc View 1 chunk +4 lines, -2 lines 2 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 1 7 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Benoit L
One less thing to rename!
3 years, 7 months ago (2017-04-27 13:34:31 UTC) #6
alexilin
lgtm https://codereview.chromium.org/2845103002/diff/20001/chrome/browser/predictors/resource_prefetcher_manager.cc File chrome/browser/predictors/resource_prefetcher_manager.cc (left): https://codereview.chromium.org/2845103002/diff/20001/chrome/browser/predictors/resource_prefetcher_manager.cc#oldcode64 chrome/browser/predictors/resource_prefetcher_manager.cc:64: base::MakeUnique<ResourcePrefetcher>(this, config_, main_frame_url, urls); Does it make a ...
3 years, 7 months ago (2017-04-27 16:39:15 UTC) #9
Benoit L
https://codereview.chromium.org/2845103002/diff/20001/chrome/browser/predictors/resource_prefetcher_manager.cc File chrome/browser/predictors/resource_prefetcher_manager.cc (left): https://codereview.chromium.org/2845103002/diff/20001/chrome/browser/predictors/resource_prefetcher_manager.cc#oldcode64 chrome/browser/predictors/resource_prefetcher_manager.cc:64: base::MakeUnique<ResourcePrefetcher>(this, config_, main_frame_url, urls); On 2017/04/27 16:39:15, alexilin wrote: ...
3 years, 7 months ago (2017-04-27 17:14:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845103002/20001
3 years, 7 months ago (2017-04-27 17:15:06 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 17:39:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1bf0b01f2d03b3d805a9dbf2ecb9...

Powered by Google App Engine
This is Rietveld 408576698