Revert of SafeBrowsing: update interstitial layouts

Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of https://codereview.chromium.org/2837233002/ )

Reason for revert:
Breaks the build, should not have been landed as NOTRY=true: https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=55642

Original issue's description:
> Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2842633002/ )
> 
> Reason for revert:
> Fixing build issues
> 
> Original issue's description:
> > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ )
> > 
> > Reason for revert:
> > This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29
> > 
> > First seen here:
> > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590
> > 
> > Original issue's description:
> > > SafeBrowsing: change interstitial sizes
> > > 
> > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > determining when to use mobile vs. desktop interstitial layouts. In
> > > particular, it targets:
> > > 
> > >  * wide and short views -> mobile landscape
> > >  * skinny and tall views -> mobile portrait
> > >  * wide and medium-height -> mobile landscape (w/ details on the same page)
> > > 
> > > The phablet layout has been removed because it seems to actually be better
> > > to just use the mobile layout instead.
> > > 
> > > This also allows the mobile layout to remain centered even for very wide
> > > views (parts of it were left-justified before), and reduces the
> > > top-margin for the icon in the mobile layout, since we were leaving a
> > > huge gap.
> > > 
> > > BUG=707481
> > > 
> > > Review-Url: https://codereview.chromium.org/2788323002
> > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51
> > 
> > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> > 
> > Review-Url: https://codereview.chromium.org/2842633002
> > Cr-Commit-Position: refs/heads/master@{#466811}
> > Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9
> 
> TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
> 
> Review-Url: https://codereview.chromium.org/2837233002
> Cr-Commit-Position: refs/heads/master@{#467789}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d24118ad102f00

TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org,ntfschr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481

[pfeldman, 2017-04-27 22:29:52]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-04-27 22:29:52]

Created Revert of SafeBrowsing: update interstitial layouts

[pfeldman, 2017-04-27 22:30:31]

Description was changed from

==========
Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of
https://codereview.chromium.org/2837233002/ )

Reason for revert:
Breaks the build, should not have been landed as NOTRY=true:
https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests...

Original issue's description:
> Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of
https://codereview.chromium.org/2842633002/ )
> 
> Reason for revert:
> Fixing build issues
> 
> Original issue's description:
> > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001
of https://codereview.chromium.org/2788323002/ )
> > 
> > Reason for revert:
> > This looks like the cause of failures here:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > 
> > First seen here:
> >
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > 
> > Original issue's description:
> > > SafeBrowsing: change interstitial sizes
> > > 
> > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > determining when to use mobile vs. desktop interstitial layouts. In
> > > particular, it targets:
> > > 
> > >  * wide and short views -> mobile landscape
> > >  * skinny and tall views -> mobile portrait
> > >  * wide and medium-height -> mobile landscape (w/ details on the same
page)
> > > 
> > > The phablet layout has been removed because it seems to actually be better
> > > to just use the mobile layout instead.
> > > 
> > > This also allows the mobile layout to remain centered even for very wide
> > > views (parts of it were left-justified before), and reduces the
> > > top-margin for the icon in the mobile layout, since we were leaving a
> > > huge gap.
> > > 
> > > BUG=707481
> > > 
> > > Review-Url: https://codereview.chromium.org/2788323002
> > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b31...
> > 
> > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> > 
> > Review-Url: https://codereview.chromium.org/2842633002
> > Cr-Commit-Position: refs/heads/master@{#466811}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee...
> 
> TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
> 
> Review-Url: https://codereview.chromium.org/2837233002
> Cr-Commit-Position: refs/heads/master@{#467789}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d2...

TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org,ntfschr@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481
==========

to

==========
Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of
https://codereview.chromium.org/2837233002/ )

Reason for revert:
Breaks the build, should not have been landed as NOTRY=true:
https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests...

Original issue's description:
> Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of
https://codereview.chromium.org/2842633002/ )
> 
> Reason for revert:
> Fixing build issues
> 
> Original issue's description:
> > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001
of https://codereview.chromium.org/2788323002/ )
> > 
> > Reason for revert:
> > This looks like the cause of failures here:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > 
> > First seen here:
> >
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...
> > 
> > Original issue's description:
> > > SafeBrowsing: change interstitial sizes
> > > 
> > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > determining when to use mobile vs. desktop interstitial layouts. In
> > > particular, it targets:
> > > 
> > >  * wide and short views -> mobile landscape
> > >  * skinny and tall views -> mobile portrait
> > >  * wide and medium-height -> mobile landscape (w/ details on the same
page)
> > > 
> > > The phablet layout has been removed because it seems to actually be better
> > > to just use the mobile layout instead.
> > > 
> > > This also allows the mobile layout to remain centered even for very wide
> > > views (parts of it were left-justified before), and reduces the
> > > top-margin for the icon in the mobile layout, since we were leaving a
> > > huge gap.
> > > 
> > > BUG=707481
> > > 
> > > Review-Url: https://codereview.chromium.org/2788323002
> > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b31...
> > 
> > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> > 
> > Review-Url: https://codereview.chromium.org/2842633002
> > Cr-Commit-Position: refs/heads/master@{#466811}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee...
> 
> TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
> 
> Review-Url: https://codereview.chromium.org/2837233002
> Cr-Commit-Position: refs/heads/master@{#467789}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d2...

TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org,ntfschr@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481
==========

[felt, 2017-04-27 22:42:00]

lgtm

(Nate, please never set NOTRY=true like that, especially when you are fixing
tests! I regret that I missed that at the end of the description.)

[Nate Fischer, 2017-04-27 22:44:54]

On 2017/04/27 22:42:00, felt wrote:
> lgtm
> 
> (Nate, please never set NOTRY=true like that, especially when you are fixing
> tests! I regret that I missed that at the end of the description.)

This was reverted in https://codereview.chromium.org/2848483004/

Sorry, didn't intend to set NOTRY. I'll keep an eye out for defaults like that.