Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2845093004: Disable failing/crashing layout tests on Site Isolation bots. (Closed)

Created:
3 years, 7 months ago by nasko
Modified:
3 years, 7 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org, lunalu1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable failing/crashing layout tests on Site Isolation bots. These tests are failing consistently on the Site Isolation FYI bots. Disabling them while they are investigated and fixed. BUG=710098, 716085 Review-Url: https://codereview.chromium.org/2845093004 Cr-Commit-Position: refs/heads/master@{#467767} Committed: https://chromium.googlesource.com/chromium/src/+/94ad18d772d3d2fbf8c084b93af70502432a4256

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate Lukasz's suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nasko
Hey Lukasz, Can you review this CL for me? It disables the currently failing layout ...
3 years, 7 months ago (2017-04-27 17:40:01 UTC) #2
Łukasz Anforowicz
LGTM, but I wonder if we should broaden the test exceptions - please see my ...
3 years, 7 months ago (2017-04-27 18:10:01 UTC) #3
Łukasz Anforowicz
+lunalu@ FYI
3 years, 7 months ago (2017-04-27 18:10:46 UTC) #4
nasko
https://codereview.chromium.org/2845093004/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/2845093004/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process#newcode12 third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:12: crbug.com/716085 virtual/mojo-loading/http/tests/feature-policy-experimental-features/vibrate-enabledforself.php [ Crash ] On 2017/04/27 18:10:00, Łukasz ...
3 years, 7 months ago (2017-04-27 18:50:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845093004/20001
3 years, 7 months ago (2017-04-27 18:50:53 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:29:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/94ad18d772d3d2fbf8c084b93af7...

Powered by Google App Engine
This is Rietveld 408576698