Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2845073002: Test network traffic annotation tag added to fileapi unittests. (Closed)

Created:
3 years, 7 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Test network traffic annotation tag added to fileapi unittests. Network traffic annotation is added to network request of: storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc storage/browser/fileapi/file_system_url_request_job_unittest.cc storage/browser/fileapi/file_writer_delegate_unittest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2845073002 Cr-Commit-Position: refs/heads/master@{#467647} Committed: https://chromium.googlesource.com/chromium/src/+/3c11446af335799e978030292e28c1a2094df608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_writer_delegate_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ramin Halavati
We are annotating all network requests in Chromium with a new NetworkTrafficAnnotation scheme. This allows ...
3 years, 7 months ago (2017-04-27 12:12:40 UTC) #6
tzik
lgtm
3 years, 7 months ago (2017-04-27 12:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845073002/1
3 years, 7 months ago (2017-04-27 12:23:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 12:26:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c11446af335799e978030292e28...

Powered by Google App Engine
This is Rietveld 408576698