Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2845053004: Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. (Closed)

Created:
3 years, 7 months ago by oshima
Modified:
3 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. * Make sure resets all shadow layers when the switching between deprecated shadow. * Don't try to show the window that is already visible. This is reland of crrev.com/2820493004 with a fix for crbug.com/713560 R=reveman@chromium.org BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. Tested on MNC and NYC devices as well. Review-Url: https://codereview.chromium.org/2837903002 Cr-Original-Commit-Position: refs/heads/master@{#467485} Committed: https://chromium.googlesource.com/chromium/src/+/27b41b0b6fb0317aa944f2bdf7e4879628aab83c Review-Url: https://codereview.chromium.org/2845053004 . Cr-Commit-Position: refs/branch-heads/3029@{#780} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c6c1349fb73e21bef5db5f9d87fb4026b9f1bfdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -30 lines) Patch
M components/exo/shell_surface.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/exo/shell_surface.cc View 10 chunks +36 lines, -26 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 7 months ago (2017-04-28 15:34:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6c1349fb73e21bef5db5f9d87fb4026b9f1bfdf.

Powered by Google App Engine
This is Rietveld 408576698