runtime/vm/native_entry.cc - Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)

Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/native_entry.cc

diff --git a/runtime/vm/native_entry.cc b/runtime/vm/native_entry.cc

index ecd4f0c268e0113cf2747e5725379fadc495e6b9..a8a3f064c35e31fa243bd260451c62e3af0025cb 100644

--- a/runtime/vm/native_entry.cc

+++ b/runtime/vm/native_entry.cc

@@ -264,7 +264,7 @@ void NativeEntry::LinkNativeCall(Dart_NativeArguments args) {

StackZone stack_zone(arguments->thread());

Zone* zone = stack_zone.GetZone();

- DartFrameIterator iterator;

+ DartFrameIterator iterator(arguments->thread(), false);

StackFrame* caller_frame = iterator.NextFrame();

const Code& code = Code::Handle(zone, caller_frame->LookupDartCode());