Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: runtime/vm/isolate_reload.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate_reload.cc
diff --git a/runtime/vm/isolate_reload.cc b/runtime/vm/isolate_reload.cc
index 4e8eac4c64e4a7b4e981f6f2f21418404515ca55..3240f0d9302ac8291e9fe749d83d6e70b1f8550a 100644
--- a/runtime/vm/isolate_reload.cc
+++ b/runtime/vm/isolate_reload.cc
@@ -772,7 +772,8 @@ void IsolateReloadContext::ReportOnJSON(JSONStream* stream) {
void IsolateReloadContext::EnsuredUnoptimizedCodeForStack() {
TIMELINE_SCOPE(EnsuredUnoptimizedCodeForStack);
- StackFrameIterator it(StackFrameIterator::kDontValidateFrames);
+ StackFrameIterator it(StackFrameIterator::kDontValidateFrames,
+ Thread::Current(), false);
Function& func = Function::Handle();
while (it.HasNextFrame()) {
@@ -1555,7 +1556,7 @@ void IsolateReloadContext::ResetUnoptimizedICsOnStack() {
Code& code = Code::Handle(zone);
Function& function = Function::Handle(zone);
- DartFrameIterator iterator;
+ DartFrameIterator iterator(thread, false);
StackFrame* frame = iterator.NextFrame();
while (frame != NULL) {
code = frame->LookupDartCode();

Powered by Google App Engine
This is Rietveld 408576698