runtime/vm/benchmark_test.cc - Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/benchmark_test.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)

Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/benchmark_test.cc

diff --git a/runtime/vm/benchmark_test.cc b/runtime/vm/benchmark_test.cc

index 83cd23f7c1472f25befcc82b312901757f82ebfb..68b7001fed31eda40c6222d16ae6f763dace0754 100644

--- a/runtime/vm/benchmark_test.cc

+++ b/runtime/vm/benchmark_test.cc

@@ -405,7 +405,8 @@ static void StackFrame_accessFrame(Dart_NativeArguments args) {

Timer timer(true, "LookupDartCode benchmark");

timer.Start();

for (int i = 0; i < kNumIterations; i++) {

- StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);

+ StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,

+ Thread::Current(), false);

StackFrame* frame = frames.NextFrame();

while (frame != NULL) {

if (frame->IsStubFrame()) {