Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2430)

Unified Diff: runtime/lib/stacktrace.cc

Issue 2845053003: Fix asserts in StackFrameIterator which were effectively disabled (Closed)
Patch Set: remote two assertions which cannot be made Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/stacktrace.cc
diff --git a/runtime/lib/stacktrace.cc b/runtime/lib/stacktrace.cc
index daf703697e833d29caf0ce4d54e296a27a1c865f..03ba749507ff1cfd696b4707b26baf27cc8a53e3 100644
--- a/runtime/lib/stacktrace.cc
+++ b/runtime/lib/stacktrace.cc
@@ -141,7 +141,8 @@ DEFINE_NATIVE_ENTRY(StackTrace_setAsyncThreadStackTrace, 1) {
static void AppendFrames(const GrowableObjectArray& code_list,
const GrowableObjectArray& pc_offset_list,
int skip_frames) {
- StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+ StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,
+ Thread::Current(), false);
StackFrame* frame = frames.NextFrame();
ASSERT(frame != NULL); // We expect to find a dart invocation frame.
Code& code = Code::Handle();
@@ -193,7 +194,8 @@ void _printCurrentStackTrace() {
// Like _printCurrentStackTrace, but works in a NoSafepointScope.
void _printCurrentStackTraceNoSafepoint() {
- StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
+ StackFrameIterator frames(StackFrameIterator::kDontValidateFrames,
+ Thread::Current(), false);
StackFrame* frame = frames.NextFrame();
while (frame != NULL) {
OS::PrintErr("%s\n", frame->ToCString());

Powered by Google App Engine
This is Rietveld 408576698