Avoid sending double responding close control frames in WebSockets

Avoid sending double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=

Review-Url: https://codereview.chromium.org/2845033002
Cr-Commit-Position: refs/heads/master@{#467964}
Committed: https://chromium.googlesource.com/chromium/src/+/cce7ad62c6fc4ee4c7cd1b32c2f1bb77c5f66dc0

[landell, 2017-04-27 08:26:25]

Description was changed from

==========
Avoid double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=
==========

to

==========
Avoid double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=
==========

[landell, 2017-04-27 08:26:25]

landell@opera.com changed reviewers:
+ yhirano@chromium.org

[landell, 2017-04-27 08:28:19]

@reviewer: PTAL
This avoids hitting state_ and close_timer_ DCHECK:s in
WebSocketChannel::RespondToClosingHandshake().

[yhirano, 2017-04-27 08:37:52]

Can we have a test?

[landell, 2017-04-27 11:00:04]

On 2017/04/27 08:37:52, yhirano wrote:
> Can we have a test?

Done.
I don't know if you have DCHECK:s enabled when running tests. This test either
hits the mentioned DCHECK or get an unexpected OnClosingHandshake call when
failing.

[yhirano, 2017-04-28 10:01:53]

lgtm

https://codereview.chromium.org/2845033002/diff/20001/net/websockets/websocke...
File net/websockets/websocket_channel_test.cc (right):

https://codereview.chromium.org/2845033002/diff/20001/net/websockets/websocke...
net/websockets/websocket_channel_test.cc:2549: static const InitFrame frames[] =
{
constexpr

[landell, 2017-04-28 10:26:08]

Description was changed from

==========
Avoid double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=
==========

to

==========
Avoid sending double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=
==========

[landell, 2017-04-28 11:00:36]

The CQ bit was checked by landell@opera.com

[landell, 2017-04-28 11:00:36]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2845033002/#ps40001
(title: "const -> constexpr")

[commit-bot: I haz the power, 2017-04-28 11:00:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 12:07:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493377236582910,
"parent_rev": "bc4bd9dfb5ff6b2f62d3985e3596df27a9bacec0", "commit_rev":
"cce7ad62c6fc4ee4c7cd1b32c2f1bb77c5f66dc0"}

[commit-bot: I haz the power, 2017-04-28 12:07:57]

Description was changed from

==========
Avoid sending double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=
==========

to

==========
Avoid sending double responding close control frames in WebSockets

This avoids sending a second ack close frame when we get a flow
control request from the renderer while waiting for the connection to
be closed.

BUG=

Review-Url: https://codereview.chromium.org/2845033002
Cr-Commit-Position: refs/heads/master@{#467964}
Committed:
https://chromium.googlesource.com/chromium/src/+/cce7ad62c6fc4ee4c7cd1b32c2f1...
==========

[commit-bot: I haz the power, 2017-04-28 12:07:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cce7ad62c6fc4ee4c7cd1b32c2f1...