Fix UI when "always translate" is enabled.

Fix UI when "always translate" is enabled.

This fix will set translate infobar with a translating status in the beginning, then highlighted the targeted language tab after translated.

Tested on my device

BUG=703887
Review-Url: https://codereview.chromium.org/2845013002
Cr-Commit-Position: refs/heads/master@{#468297}
Committed: https://chromium.googlesource.com/chromium/src/+/67ed5fd8781049a3566ce37426bceae03bca942d

[Leo, 2017-05-01 04:11:54]

Description was changed from

==========
Fix UI when "always translate" is enabled.

This fix will set infobar with translating status in the beginning.

Tested on my device

BUG=703887
==========

to

==========
Fix UI when "always translate" is enabled.

This fix will set translate infobar with a translating status in the beginning,
then highlighted the targeted language tab after translated.

Tested on my device

BUG=703887
==========

[Leo, 2017-05-01 04:11:54]

googleo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Leo, 2017-05-01 04:14:43]

Hey Dan,

This CL will pass the translate step to compact translate infobar to decide
whether to show translating status when it's initialized.

[Leo, 2017-05-01 04:14:58]

The CQ bit was checked by googleo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 04:15:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 05:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 05:04:21]

Dry run: This issue passed the CQ dry run.

[gone, 2017-05-01 05:34:20]

lgtm

https://codereview.chromium.org/2845013002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2845013002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:69:
// Set translating status in the beginning
End sentences with periods.

[gone, 2017-05-01 05:34:58]

You guys should really consider starting to add tests, here.

[Leo, 2017-05-01 05:50:13]

On 2017/05/01 05:34:58, slow (dfalcantara) wrote:
> You guys should really consider starting to add tests, here.

Sure, thanks for the reminding.

More specifically, should we add all new steps testing in
https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromiu...

and verify the UI or logic?

[Leo, 2017-05-01 05:51:15]

Thanks

https://codereview.chromium.org/2845013002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2845013002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:69:
// Set translating status in the beginning
On 2017/05/01 05:34:20, slow (dfalcantara) wrote:
> End sentences with periods.

Done.

[Leo, 2017-05-01 05:52:57]

The CQ bit was checked by googleo@chromium.org

[Leo, 2017-05-01 05:52:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2845013002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-05-01 05:53:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 06:46:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493617977531970,
"parent_rev": "1df8e5abe3d4a6b90c62f113f35ff41974fe64b6", "commit_rev":
"67ed5fd8781049a3566ce37426bceae03bca942d"}

[commit-bot: I haz the power, 2017-05-01 06:46:19]

Description was changed from

==========
Fix UI when "always translate" is enabled.

This fix will set translate infobar with a translating status in the beginning,
then highlighted the targeted language tab after translated.

Tested on my device

BUG=703887
==========

to

==========
Fix UI when "always translate" is enabled.

This fix will set translate infobar with a translating status in the beginning,
then highlighted the targeted language tab after translated.

Tested on my device

BUG=703887

Review-Url: https://codereview.chromium.org/2845013002
Cr-Commit-Position: refs/heads/master@{#468297}
Committed:
https://chromium.googlesource.com/chromium/src/+/67ed5fd8781049a3566ce37426bc...
==========

[commit-bot: I haz the power, 2017-05-01 06:46:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/67ed5fd8781049a3566ce37426bc...

[gone, 2017-05-01 15:23:46]

I'd just make a new suite.  You need to start at least testing logic so that
this situation doesn't happen again.  If parts of the UI are stable enough, you
should also start adding tests for those.