Rework the vboot_reference make system.

Rework the vboot_reference make system.

After this change the generated files are placed in a
separate tree (such thet they don't show in the
`git status' output anymore) and the dependencies are
followed properly (if a .h file changes the
appropriate .o files and apps get rebuilt).

Tested as follows:

> $ make clean
> $ make # build succeeds
> $ git status # shows clean directory
> $ RUNTESTS=1 make # (captured test output matches that of the test run before any changes)
> $ touch ./vboot_firmware/include/tlcl.h
> $ make  # make succeeds
> $ find build -type f -newer ./vboot_firmware/include/tlcl.h
build/vboot_firmware/lib/rollback_index.o
build/vboot_firmware/lib/rollback_index.o.d
build/vboot_firmware/a.out
build/vboot_fw.a
build/utility/vbutil_key
build/utility/kernel_utility.d
build/utility/vbutil_key.d
build/utility/verify_data
build/utility/load_kernel_test.d
build/utility/vbutil_keyblock.d
build/utility/vbutil_kernel
build/utility/vbutil_kernel.d
build/utility/firmware_utility
build/utility/signature_digest_utility.d
build/utility/kernel_utility
build/utility/verify_data.d
build/utility/vbutil_keyblock
build/utility/signature_digest_utility
build/utility/load_kernel_test
build/utility/firmware_utility.d
build/tests/vboot_common3_tests
build/tests/vboot_common2_tests
build/host/a.out
$ >

[Bill Richardson, 2010-06-14 18:16:26]

A couple of comments. Plus, be sure to test this from within the chroot by
running both of these commands:

  sudo emerge vboot_reference
  emerge-x86-generic vboot_reference

http://codereview.chromium.org/2845001/diff/2001/3002
File Makefile (right):

http://codereview.chromium.org/2845001/diff/2001/3002#newcode6
Makefile:6: export CXX = g++
No, we need to keep the ?= so that we don't force gcc or g++. Otherwise we can't
build cgpt for the target.

http://codereview.chromium.org/2845001/diff/2001/3008
File tests/Makefile (right):

http://codereview.chromium.org/2845001/diff/2001/3008#newcode141
tests/Makefile:141: ${BUILD_ROOT}/cgptlib_test
Pass ${BUILD_ROOT}/cgpt/cgpt as the argument to cgptlib_test, so that we're sure
the script uses the correct path to the executable.

http://codereview.chromium.org/2845001/diff/2001/3011
File tests/run_cgpt_tests.sh (right):

http://codereview.chromium.org/2845001/diff/2001/3011#newcode12
tests/run_cgpt_tests.sh:12: GPT=${1:-../build/cgpt/cgpt}
This is fine  Now that we have an explict $BUILD_ROOT, we should pass the full
path to the binary as the first arg (from tests/Makefile -- see my comment
there).

[vb, 2010-06-14 22:17:43]

Bill, I addressed your comments and verified that local
emerge works for both x86 and arm platforms. The partial 
ebuild change is under http://codereview.chromium.org/2852001 
(will be completed once the source code change is checked 
in).

On top of the package tests I verified that local ebuild 
succeeds for both x86 and arm platforms.

http://codereview.chromium.org/2845001/diff/2001/3002
File Makefile (right):

http://codereview.chromium.org/2845001/diff/2001/3002#newcode6
Makefile:6: export CXX = g++
On 2010/06/14 18:16:27, Bill Richardson wrote:
> No, we need to keep the ?= so that we don't force gcc or g++. Otherwise we
can't
> build cgpt for the target.

Done.

http://codereview.chromium.org/2845001/diff/2001/3008
File tests/Makefile (right):

http://codereview.chromium.org/2845001/diff/2001/3008#newcode141
tests/Makefile:141: ${BUILD_ROOT}/cgptlib_test
On 2010/06/14 18:16:27, Bill Richardson wrote:
> Pass ${BUILD_ROOT}/cgpt/cgpt as the argument to cgptlib_test, so that we're
sure
> the script uses the correct path to the executable.

Done.

http://codereview.chromium.org/2845001/diff/2001/3011
File tests/run_cgpt_tests.sh (right):

http://codereview.chromium.org/2845001/diff/2001/3011#newcode12
tests/run_cgpt_tests.sh:12: GPT=${1:-../build/cgpt/cgpt}
On 2010/06/14 18:16:27, Bill Richardson wrote:
> This is fine  Now that we have an explict $BUILD_ROOT, we should pass the full
> path to the binary as the first arg (from tests/Makefile -- see my comment
> there).

Done.

[Bill Richardson, 2010-06-14 22:33:29]

LGTM

Thanks!