Issue 2852001: Prepare vboot_reference ebuild to work with the new makefile and build flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2852001: Prepare vboot_reference ebuild to work with the new makefile and build flow. (Closed)

Created:
10 years, 6 months ago by vb

Modified:
9 years, 6 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines

Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git

Visibility:
Public.

Description

Prepare vboot_reference ebuild to work with the new makefile and build flow. It works for local build only, will address pulling source with the git after http://codereview.chromium.org/2845001 has been submitted.

Patch Set 1 : Prepare vboot_reference ebuild to work with the new makefile and build flow. #

Total comments: 2

Patch Set 2 : Modified based on the review comments #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -18 lines)			Patch
	M	chromeos-base/vboot_reference/vboot_reference-1.0.ebuild	View	1	2 chunks	+8 lines, -18 lines	0 comments	Download
	A	chromeos-base/vboot_reference/vboot_reference-9999.ebuild	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

http://codereview.chromium.org/2852001/diff/6001/7001 File chromeos-base/vboot_reference/vboot_reference-1.0.ebuild (right): http://codereview.chromium.org/2852001/diff/6001/7001#newcode22 chromeos-base/vboot_reference/vboot_reference-1.0.ebuild:22: "Try running 'make clean' in the package root directory" ...

10 years, 6 months ago (2010-06-14 22:26:43 UTC) #2

10 years, 6 months ago (2010-06-14 22:43:36 UTC) #3

Okay. LGTM, then.

Thanks.

Expand Messages | Collapse Messages