Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2844993005: Remove explicit v8::DEFAULT argument to SetAccessorProperty and SetNativeDataProperty (Closed)

Created:
3 years, 7 months ago by Toon Verwaest
Modified:
3 years, 7 months ago
Reviewers:
haraken, Mike West
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove explicit v8::DEFAULT argument to SetAccessorProperty and SetNativeDataProperty BUG= Review-Url: https://codereview.chromium.org/2844993005 Cr-Commit-Position: refs/heads/master@{#467959} Committed: https://chromium.googlesource.com/chromium/src/+/c4e107b2910aed777192a260b876c46422c945e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Toon Verwaest
ptal
3 years, 7 months ago (2017-04-28 07:57:42 UTC) #5
haraken
LGTM
3 years, 7 months ago (2017-04-28 08:07:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844993005/1
3 years, 7 months ago (2017-04-28 09:15:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 11:23:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4e107b2910aed777192a260b876...

Powered by Google App Engine
This is Rietveld 408576698